Skip to content

fix(trainer): fix __all__ import. #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 23, 2025
Merged

fix(trainer): fix __all__ import. #43

merged 3 commits into from
Jul 23, 2025

Conversation

@Electronic-Waste
Copy link
Member

@Electronic-Waste Electronic-Waste commented Jul 23, 2025 •
edited
Loading

What this PR does / why we need it:

Current __all__ for package import omits several items: TrainerClient, DATASET_PATH and MODEL_PATH. This prevents users from using TrainerClient through from kubeflow.trainer import *.

In this PR, I adds them to __all__ array:)

/cc @kubeflow/wg-training-leads @astefanutti @eoinfennessy

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):

Fixes #

Checklist:

  • Docs included if any changes are user facing

@Electronic-Waste
fix(trainer): fix __all__ import.
bbbf22a 
Signed-off-by: Electronic-Waste <2690692950@qq.com>
@Electronic-Waste
fix(trainer): alphabetic order.
a59f65a 
Signed-off-by: Electronic-Waste <2690692950@qq.com>
@google-oss-prow google-oss-prow bot requested review from a team and astefanutti July 23, 2025 06:12
@google-oss-prow
Copy link

@Electronic-Waste: GitHub didn't allow me to request PR reviews from the following users: eoinfennessy.

Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

What this PR does / why we need it:

Current __all__ for package import omits several items: TrainerClient, DATASET_PATH and MODEL_PATH.

In this PR, I adds them to __all__ array:)

/cc @kubeflow/wg-training-leads @astefanutti @eoinfennessy

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):

Fixes #

Checklist:

  • Docs included if any changes are user facing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Electronic-Waste
fix(lint): fix lint error.
318dc78 
Signed-off-by: Electronic-Waste <2690692950@qq.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 16463017116

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 64.752%
Totals Coverage Status
Change from base Build 16428051577: 0.0%
Covered Lines: 248
Relevant Lines: 383
💛 - Coveralls

@kramaranya
Copy link
Contributor

Great, thank you!
/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Jul 23, 2025
@Electronic-Waste
Copy link
Member Author

Thanks @kramaranya!
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Electronic-Waste

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 932cc03 into kubeflow:main Jul 23, 2025
9 checks passed
@google-oss-prow google-oss-prow bot added this to the v0.1 milestone Jul 23, 2025
@Electronic-Waste Electronic-Waste deleted the fix/import-trainer branch July 23, 2025 10:12
kramaranya pushed a commit to kramaranya/sdk that referenced this pull request Jul 24, 2025
@Electronic-Waste @kramaranya
fix(trainer): fix __all__ import. (kubeflow#43)
8941c13 
* fix(trainer): fix __all__ import.

Signed-off-by: Electronic-Waste <2690692950@qq.com>

* fix(trainer): alphabetic order.

Signed-off-by: Electronic-Waste <2690692950@qq.com>

* fix(lint): fix lint error.

Signed-off-by: Electronic-Waste <2690692950@qq.com>

---------

Signed-off-by: Electronic-Waste <2690692950@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@astefanutti astefanutti Awaiting requested review from astefanutti

Assignees

@kramaranya kramaranya

Labels

approved lgtm size/XS

Projects

None yet

Milestone

v0.1

Development

Successfully merging this pull request may close these issues.

3 participants

@Electronic-Waste @coveralls @kramaranya